carp84 commented on a change in pull request #195: HBASE-22322 Use special
pause for CallQueueTooBigException
URL: https://github.com/apache/hbase/pull/195#discussion_r279230978
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdminBuilder.java
##########
@@ -36,34 +36,40 @@
* Set timeout for a whole admin operation. Operation timeout and max
attempt times(or max retry
* times) are both limitations for retrying, we will stop retrying when we
reach any of the
* limitations.
- * @param timeout
- * @param unit
* @return this for invocation chaining
*/
AsyncAdminBuilder setOperationTimeout(long timeout, TimeUnit unit);
/**
* Set timeout for each rpc request.
- * @param timeout
- * @param unit
* @return this for invocation chaining
*/
AsyncAdminBuilder setRpcTimeout(long timeout, TimeUnit unit);
/**
* Set the base pause time for retrying. We use an exponential policy to
generate sleep time when
* retrying.
- * @param timeout
- * @param unit
* @return this for invocation chaining
+ * @see #setRetryPauseForCQTBE(long, TimeUnit)
*/
AsyncAdminBuilder setRetryPause(long timeout, TimeUnit unit);
+ /**
+ * Set the base pause time for retrying when we hit {@code
CallQueueTooBigException}. We use an
+ * exponential policy to generate sleep time when retrying.
+ * <p/>
+ * This value should be greater than the normal pause value which could be
set with the above
+ * {@link #setRetryPause(long, TimeUnit)} method, as usually {@code
CallQueueTooBigException}
+ * means the server is overloaded. We just use the normal pause value for
+ * {@code CallQueueTooBigException} if here you specify a smaller value.
+ * @see #setRetryPause(long, TimeUnit)
+ */
+ AsyncAdminBuilder setRetryPauseForCQTBE(long pause, TimeUnit unit);
+
/**
* Set the max retry times for an admin operation. Usually it is the max
attempt times minus 1.
* Operation timeout and max attempt times(or max retry times) are both
limitations for retrying,
* we will stop retrying when we reach any of the limitations.
- * @param maxRetries
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
