[
https://issues.apache.org/jira/browse/HBASE-22323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829014#comment-16829014
]
Jan Hentschel edited comment on HBASE-22323 at 4/29/19 8:20 AM:
----------------------------------------------------------------
As far as I can see the nightly didn't catch that one. But would be great to
have it in the precommit (similar to Checkstyle), because it is easy to miss.
was (Author: jan hentschel):
As far as I can see the nightly didn't catch that one.
> Thrift generation broken
> ------------------------
>
> Key: HBASE-22323
> URL: https://issues.apache.org/jira/browse/HBASE-22323
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 3.0.0
> Reporter: Jan Hentschel
> Assignee: Jan Hentschel
> Priority: Major
>
> HBASE-22232 made changes to the Thrift definition switching {{TCompareOp}} to
> {{TCompareOperator}}. This change led to the following errors:
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile
> (default-compile) on project hbase-thrift: Compilation failure: Compilation
> failure:
> [ERROR]
> /home//hbase/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftTable.java:[419,73]
> incompatible types: org.apache.hadoop.hbase.thrift2.generated.TCompareOp
> cannot be converted to
> org.apache.hadoop.hbase.thrift2.generated.TCompareOperator
> [ERROR]
> /home/hbase/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java:[99,8]
> org.apache.hadoop.hbase.thrift2.ThriftHBaseServiceHandler is not abstract
> and does not override abstract method
> checkAndMutate(java.nio.ByteBuffer,java.nio.ByteBuffer,java.nio.ByteBuffer,java.nio.ByteBuffer,org.apache.hadoop.hbase.thrift2.generated.TCompareOperator,java.nio.ByteBuffer,org.apache.hadoop.hbase.thrift2.generated.TRowMutations)
> in org.apache.hadoop.hbase.thrift2.generated.THBaseService.Iface
> [ERROR]
> /home/hbase/hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java:[341,3]
> method does not override or implement a method from a supertype
> {code}
> This errors need to be resolved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
