petersomogyi commented on a change in pull request #30: HBASE-22329 Fix for
warning The parameter forkMode is deprecated since
URL: https://github.com/apache/hbase-connectors/pull/30#discussion_r279502523
##########
File path: spark/hbase-spark-it/pom.xml
##########
@@ -103,7 +103,8 @@
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<skip>false</skip>
- <forkMode>always</forkMode>
+ <forkCount>1</forkCount>
+ <reuseForks>true</reuseForks>
Review comment:
The
[documentation](https://maven.apache.org/surefire/maven-failsafe-plugin/examples/fork-options-and-parallel-execution.html)
at _Migrating the Deprecated forkMode Parameter to forkCount and reuseForks_
says forkMode=always is equivalent with forkCount=1 (default) and
reuseForks=false. However, not reusing the processes would add an overhead so I
think it is a reasonable modification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
