Apache9 commented on a change in pull request #209: HBASE-21070 Fix
SnapshotFileCache for HBase backed by S3
URL: https://github.com/apache/hbase/pull/209#discussion_r280065828
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
##########
@@ -305,6 +313,10 @@ public boolean isStopped() {
return this.stop;
}
+ protected long getLastModifiedTime() {
Review comment:
Make it package private and add a VisibleForTesting annotation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
