[
https://issues.apache.org/jira/browse/HBASE-21777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833510#comment-16833510
]
Yu Li edited comment on HBASE-21777 at 5/6/19 3:34 AM:
-------------------------------------------------------
In branch-2 [~stack] has changed to only print the log message when TRACE
enabled and added a TODO (in HBASE-17844), like below:
{code}
+ if (LOG.isTraceEnabled()) {
+ // TODO: FIX!!! Don't log unless some activity or a change in config.
Making TRACE
+ // in the meantime.
+ LOG.trace("CompactionPressure is " + compactionPressure + ", tune
throughput to "
+ throughputDesc(maxThroughputToSet));
}
{code}
The main debate here is whether changing to TRACE is a better idea, in which
way we could still display the log by dynamically change the log level from RS
webUI.
was (Author: carp84):
In branch-2 [~stack] has changed to only print the log message when TRACE
enabled and added a TODO, like below:
{code}
+ if (LOG.isTraceEnabled()) {
+ // TODO: FIX!!! Don't log unless some activity or a change in config.
Making TRACE
+ // in the meantime.
+ LOG.trace("CompactionPressure is " + compactionPressure + ", tune
throughput to "
+ throughputDesc(maxThroughputToSet));
}
{code}
The main debate here is whether changing to TRACE is a better idea, in which
way we could still display the log by dynamically change the log level from RS
webUI.
> "Tune compaction throughput" debug messages even when nothing has changed
> --------------------------------------------------------------------------
>
> Key: HBASE-21777
> URL: https://issues.apache.org/jira/browse/HBASE-21777
> Project: HBase
> Issue Type: Bug
> Components: Compaction
> Affects Versions: 1.5.0
> Reporter: Andrew Purtell
> Assignee: Tak Lon (Stephen) Wu
> Priority: Trivial
> Labels: branch-1
> Fix For: 1.5.0
>
>
> PressureAwareCompactionThroughputController will log "tune compaction
> throughput" debug messages even when after consideration the re-tuning makes
> no change to current settings. In that case it would be better not to log
> anything.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
