[ 
https://issues.apache.org/jira/browse/HBASE-21777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16833517#comment-16833517
 ] 

Yu Li commented on HBASE-21777:
-------------------------------

Maybe combining both is a better idea, please let me know how you feel about 
the following sample:
{code}
    if (LOG.isDebugEnabled()) {
      if (maxThroughputToSet != getMaxThroughput()) {
        LOG.debug("CompactionPressure is " + compactionPressure + ", tune 
throughput to "
            + throughputDesc(maxThroughputToSet));
      } else if (LOG.isTraceEnabled()) {
        LOG.trace("CompactionPressure is " + compactionPressure + ", keep 
throughput throttling to "
            + throughputDesc(maxThroughputToSet));
      }
    }
{code}
Thanks.

> "Tune compaction throughput" debug messages even when nothing has changed 
> --------------------------------------------------------------------------
>
>                 Key: HBASE-21777
>                 URL: https://issues.apache.org/jira/browse/HBASE-21777
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 1.5.0
>            Reporter: Andrew Purtell
>            Assignee: Tak Lon (Stephen) Wu
>            Priority: Trivial
>              Labels: branch-1
>             Fix For: 1.5.0
>
>
> PressureAwareCompactionThroughputController will log "tune compaction 
> throughput" debug messages even when after consideration the re-tuning makes 
> no change to current settings. In that case it would be better not to log 
> anything.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to