[ 
https://issues.apache.org/jira/browse/HBASE-22386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16837355#comment-16837355
 ] 

Wellington Chevreuil commented on HBASE-22386:
----------------------------------------------

Compilation error is sorted. However, had applied this second patch on top of 
master branch latest commit, but am getting test errors now:

{noformat}
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:176->createConfiguration:36->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRename>AbstractFSContractTestBase.setup:176->createContract:49->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRename>AbstractFSContractTestBase.setup:176->createContract:49->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:176->createContract:52->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:176->createContract:52->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:176->createContract:52->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR]   
TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:176->createContract:52->Assert.fail:88
 Exception configuring FS: java.io.IOException: Unable to initialize root znodes
[ERROR] Errors: 
[ERROR]   TestAtomicRename>HBaseObjectStoreSemanticsTest.setup:57 » IO 
Exception while e...
[ERROR]   TestCreateNonRecursive>HBaseObjectStoreSemanticsTest.setup:55 » IO 
Unable to i...
[ERROR]   TestRecursiveDelete>HBaseObjectStoreSemanticsTest.setup:55 » IO 
Unable to init...
[ERROR]   TestTreeLockManager>HBaseObjectStoreSemanticsTest.setup:57 » IO 
Exception whil...
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testDeleteNonExistentFile:403 » IO
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testListStatusRootDir:844->FileSystemContractBaseTest.createFile:588
 » IO
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract>FileSystemContractBaseTest.testMkdirs:189 » IO 
Exception whi...
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testMoveFileUnderParent:821->FileSystemContractBaseTest.createFile:588
 » IO
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testMultiByteFilesAreFiles:682 » IO
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testOutputStreamClosedTwice:581 » 
IO
[ERROR]   TestHBOSSContract>FileSystemContractBaseTest.testOverwrite:366 » IO 
Exception ...
[ERROR]   TestHBOSSContract.testRenameDirectoryAsExistingDirectory:83 » IO 
Exception whi...
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testRenameDirectoryAsExistingFile:536
 » IO
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testRenameDirectoryMoveToExistingDirectory:513
 » IO
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testRenameFileAsExistingDirectory:491->FileSystemContractBaseTest.createFile:588
 » IO
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testWriteInNonExistentDirectory:392
 » IO
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   TestHBOSSContract.setUp:54 » IO Unable to initialize root znodes
[ERROR]   
TestHBOSSContract>FileSystemContractBaseTest.testWriteReadAndDeleteTwoBlocks:348->FileSystemContractBaseTest.writeReadAndDelete:359->FileSystemContractBaseTest.writeAndRead:924
 » IO
[ERROR]   
TestHBOSSContractAppend>AbstractContractAppendTest.setup:43->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractAppend>AbstractContractAppendTest.setup:43->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractConcat>AbstractContractConcatTest.setup:47->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractConcat>AbstractContractConcatTest.setup:47->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractConcat>AbstractContractConcatTest.setup:47->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractConcat>AbstractContractConcatTest.setup:47->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractCreate>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   TestHBOSSContractCreate>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractCreate>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractCreate>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractDelete>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractDelete>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractDelete>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   TestHBOSSContractDelete>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   
TestHBOSSContractDelete>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractDelete>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   TestHBOSSContractDelete>AbstractFSContractTestBase.setup:181 » IO 
Failed to ge...
[ERROR]   
TestHBOSSContractDistCp>AbstractContractDistCpTest.setup:138->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractDistCp>AbstractContractDistCpTest.setup:138->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractGetFileStatus>AbstractContractGetFileStatusTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   TestHBOSSContractMkdir>AbstractFSContractTestBase.setup:181 » IO 
Failed to get...
[ERROR]   TestHBOSSContractMkdir>AbstractFSContractTestBase.setup:181 » IO 
Failed to get...
[ERROR]   TestHBOSSContractMkdir>AbstractFSContractTestBase.setup:181 » IO 
Failed to get...
[ERROR]   
TestHBOSSContractMkdir>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractOpen>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractOpen>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractOpen>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:181 » IO 
Failed to...
[ERROR]   TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:181 » IO 
Failed to...
[ERROR]   
TestHBOSSContractRenameS3A>AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractRootDirectory>AbstractContractRootDirectoryTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractRootDirectory>AbstractContractRootDirectoryTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractRootDirectory>AbstractContractRootDirectoryTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractRootDirectory>AbstractContractRootDirectoryTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractRootDirectory>AbstractContractRootDirectoryTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSeek>AbstractContractSeekTest.setup:56->AbstractFSContractTestBase.setup:181
 » IO
[ERROR]   
TestHBOSSContractSetTimes>AbstractContractSetTimesTest.setup:41->AbstractFSContractTestBase.setup:193->AbstractFSContractTestBase.mkdirs:338
 » IO
[INFO] 
[ERROR] Tests run: 160, Failures: 12, Errors: 81, Skipped: 13
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE

{noformat}



> HBOSS: Limit depth that listing locks check for other locks
> -----------------------------------------------------------
>
>                 Key: HBASE-22386
>                 URL: https://issues.apache.org/jira/browse/HBASE-22386
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Major
>         Attachments: HBASE-22386.001.patch, HBASE-22386.002.patch
>
>
> treeWriteLock will check all the way up and down the tree for locks. This is 
> more aggressive than it needs to be, and integration testing has shown that 
> there's significant contention when listing tables, and this is one of 
> numerous operations that doesn't need to recursively lock the whole subtree. 
> There's actually a number of operations that only need to lock up or down 1 
> level only, so let's start with listing: non-recursive listings don't need to 
> care about what's going on more than 1 level below them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to