Apache9 commented on a change in pull request #168: HBASE-22271 Implement
grant/revoke/delete table acls/delete namespace acls in Procedure
URL: https://github.com/apache/hbase/pull/168#discussion_r283610247
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -2712,10 +2713,11 @@ public GrantResponse grant(RpcController controller,
GrantRequest request)
if (master.cpHost != null) {
master.cpHost.preGrant(perm, mergeExistingPermissions);
}
- try (Table table =
master.getConnection().getTable(PermissionStorage.ACL_TABLE_NAME)) {
- PermissionStorage.addUserPermission(getConfiguration(), perm, table,
- mergeExistingPermissions);
- }
+ ProcedurePrepareLatch latch =
ProcedurePrepareLatch.createBlockingLatch();
Review comment:
Maybe a better way is to add a proc id field in GrantResponse, and query the
result at client side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
