[ 
https://issues.apache.org/jira/browse/HBASE-22393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16839322#comment-16839322
 ] 

Wellington Chevreuil commented on HBASE-22393:
----------------------------------------------

Tested latest patch. It's shading *org.apache.log4j*, but it's missing *log4j* 
in the _includes_ section, so am getting class not found while trying to start 
RSes:
{noformat}
2019-05-14 03:47:13,301 ERROR 
org.apache.hadoop.hbase.regionserver.HRegionServer: Failed construction 
RegionServer
java.lang.NoClassDefFoundError: 
org/apache/hadoop/hbase/oss/thirdparty/org/apache/log4j/Level
        at 
org.apache.hadoop.hbase.oss.thirdparty.org.slf4j.LoggerFactory.bind(LoggerFactory.java:150)
        at 
org.apache.hadoop.hbase.oss.thirdparty.org.slf4j.LoggerFactory.performInitialization(LoggerFactory.java:124)
        at 
org.apache.hadoop.hbase.oss.thirdparty.org.slf4j.LoggerFactory.getILoggerFactory(LoggerFactory.java:412)
        at 
org.apache.hadoop.hbase.oss.thirdparty.org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:357)
        at 
org.apache.hadoop.hbase.oss.thirdparty.org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:383)
        at 
org.apache.hadoop.hbase.oss.HBaseObjectStoreSemantics.<clinit>(HBaseObjectStoreSemantics.java:98)
{noformat}
Also faced similar issues with *javax* related classes. I don't think we really 
need to shade it, since it's platform provided, we wouldn't face version 
conflicts here, right?

I had managed to have it working by adding *log4j* in the _includes_ section 
and removing _relocation_ definition for *javax*.

> HBOSS: Shade curator to prevent conflict with Hadoop
> ----------------------------------------------------
>
>                 Key: HBASE-22393
>                 URL: https://issues.apache.org/jira/browse/HBASE-22393
>             Project: HBase
>          Issue Type: Bug
>          Components: Filesystem Integration
>    Affects Versions: hbase-filesystem-1.0.0-alpha1
>            Reporter: Sean Mackrory
>            Assignee: Sean Mackrory
>            Priority: Critical
>             Fix For: hbase-filesystem-1.0.0-alpha1
>
>         Attachments: HBASE-22393.001.patch, HBASE-22393.002.patch
>
>
> Hadoop uses a very old version of Curator, and if it ever ends up in the 
> classpath with HBOSS you can get this:
> {code}Exception in thread "main" java.lang.IllegalAccessError: tried to 
> access method 
> org.apache.curator.framework.recipes.locks.InterProcessMutex.isOwnedByCurrentThread()Z
>  from class org.apache.hadoop.hbase.oss.sync.ZKTreeLockManager{code}
> I think the simplest solution is to just shade Curator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to