[
https://issues.apache.org/jira/browse/HBASE-22184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840302#comment-16840302
]
Reid Chan commented on HBASE-22184:
-----------------------------------
LGTM.
Just few nits,
This style `index+1` to `index + 1`, there're few places, please check.
{code}
// Miss empty space between *HTTP, and true
testDynamicLogLevel(LogLevel.PROTOCOL_HTTP, LogLevel.PROTOCOL_HTTP,true,
"INFO");
{code}
Thank you [~jojochuang], it's a good feature.
> [security] Support get|set LogLevel in HTTPS mode
> -------------------------------------------------
>
> Key: HBASE-22184
> URL: https://issues.apache.org/jira/browse/HBASE-22184
> Project: HBase
> Issue Type: Improvement
> Components: logging, website
> Reporter: Reid Chan
> Assignee: Wei-Chiu Chuang
> Priority: Major
> Labels: security
> Attachments: HBASE-22184.master.001.patch,
> HBASE-22184.master.002.patch
>
>
> As title read.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
