Apache9 commented on a change in pull request #237: HBASE-22408 add dead and
unknown server open regions metric to AM 01
URL: https://github.com/apache/hbase/pull/237#discussion_r284516470
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -620,8 +620,7 @@ public synchronized boolean expireServer(final ServerName
serverName) {
}
}
- @VisibleForTesting
- public void moveFromOnlineToDeadServers(final ServerName sn) {
+ public synchronized void moveFromOnlineToDeadServers(final ServerName sn) {
Review comment:
Checked the code, it is used for HBCK2 so I do not think synchronized is
necessary there as it is a human operation. Anyway it is fine to synchronized
for now, can review it later. But please add the VisibleForTesting back, that's
why we make it public, otherwise we can make it package private. This can also
be polished later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
