[
https://issues.apache.org/jira/browse/HBASE-5573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237089#comment-13237089
]
stack commented on HBASE-5573:
------------------------------
Patch looks good. Only question is the one I had yesterday where in
HBaseTestingUtility#getZooKeeperWatcher, if its aborted, it does nothing but
this ZKW is being used by test code so I'd think if an abort, it shouldn't be
suppressed -- rather we should complain loudly? Rethrow as RuntimeException?
Do you want to be consistent? You call methods getZKW most times and then
getZooKeeperWatcher in this test code (I prefer the latter).
> Replace client ZooKeeper watchers by simple ZooKeeper reads
> -----------------------------------------------------------
>
> Key: HBASE-5573
> URL: https://issues.apache.org/jira/browse/HBASE-5573
> Project: HBase
> Issue Type: Improvement
> Components: client, zookeeper
> Affects Versions: 0.96.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5573.v1.patch, 5573.v2.patch, 5573.v4.patch,
> 5573.v6.patch
>
>
> Some code in the package needs to read data in ZK. This could be done by a
> simple read, but is actually implemented with a watcher. This holds ZK
> resources.
> Fixing this could also be an opportunity to remove the need for the client to
> provide the master address and port.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
