[ https://issues.apache.org/jira/browse/HBASE-22413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842382#comment-16842382 ]
Andrew Purtell commented on HBASE-22413: ---------------------------------------- bq. We shouldn't be doing this. If we need to change these log levels we should do it via src/test/resources There are a couple other tests that reach in and twiddle directly with log levels too. I propose this: For this patch, provide a branch-1 patch that uses Apache Commons Logging and Log4J instead of SLF4J. SLF4J is a branch-2 thing. Then file a follow up for removing these hacks from unit tests. It's a bit nontrivial because some tests need to do it as part of their function if I recall correctly, and you don't want to make the changes universally in a resource shared among all tests. > Backport 'HBASE-22399 Change default hadoop-two.version to 2.8.x and remove > the 2.7.x hadoop checks' to branch-1 > ---------------------------------------------------------------------------------------------------------------- > > Key: HBASE-22413 > URL: https://issues.apache.org/jira/browse/HBASE-22413 > Project: HBase > Issue Type: Sub-task > Reporter: Duo Zhang > Assignee: Duo Zhang > Priority: Major > Fix For: 1.5.0 > > Attachments: HBASE-22413-branch-1-v1.patch, > HBASE-22413-branch-1-v1.patch, HBASE-22413-branch-1-v2.patch, > HBASE-22413-branch-1-v3.patch, HBASE-22413-branch-1.patch, > HBASE-22413-branch-1.patch, HBASE-22413-branch-1.patch, > HBASE-22413-branch-1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)