[ 
https://issues.apache.org/jira/browse/HBASE-22169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842812#comment-16842812
 ] 

stack commented on HBASE-22169:
-------------------------------

I tried apply this. It seemed ok on branch-2.1 though it'd fail on occasion. I 
ran the test on master branch and it did this:

{code}
 -------------------------------------------------------------------------------
 Test set: org.apache.hadoop.hbase.regionserver.TestHRegion
 -------------------------------------------------------------------------------
 Tests run: 60, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 780.443 s <<< 
FAILURE! - in org.apache.hadoop.hbase.regionserver.TestHRegion
 org.apache.hadoop.hbase.regionserver.TestHRegion  Time elapsed: 717.422 s  <<< 
ERROR!
 org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds
   at 
app//org.apache.hadoop.hbase.regionserver.TestHRegion.testOpenRegionFailedMemoryLeak(TestHRegion.java:6306)
{code}

Let me revert the commits on branch-2.1 and branch-2.2 for now until above is 
resolved. I'll put up what I cherry-picked.

> Open region failed cause memory leak
> ------------------------------------
>
>                 Key: HBASE-22169
>                 URL: https://issues.apache.org/jira/browse/HBASE-22169
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.5, 2.1.4
>            Reporter: Bing Xiao
>            Assignee: Bing Xiao
>            Priority: Critical
>             Fix For: 3.0.0, 2.1.5, 2.2.1
>
>         Attachments: HBASE-22169-master-v1.patch, HBASE-22169-master-v2.patch
>
>
> In some cases (for example, coprocessor path is wrong) region open failed, 
> MetricsRegionWrapperImpl is already init and not close, cause memory leak;
> {code:java}
> 2019-02-21 15:41:32,929 ERROR 
> [RS_OPEN_REGION-hb-2zedsc3fxjn12dl6u-005:16020-7] 
> regionserver.RegionCoprocessorHost(362): Failed to load coprocessor 
> org.apache.kylin.storage.hbase.cube.v2.coprocessor.endpoint.CubeVisitService
> java.lang.IllegalArgumentException: java.net.UnknownHostException: emr-cluster
> at 
> org.apache.hadoop.security.SecurityUtil.buildTokenService(SecurityUtil.java:378)
> at 
> org.apache.hadoop.hdfs.NameNodeProxies.createNonHAProxy(NameNodeProxies.java:310)
> at 
> org.apache.hadoop.hdfs.NameNodeProxies.createProxy(NameNodeProxies.java:176)
> at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:678)
> at org.apache.hadoop.hdfs.DFSClient.<init>(DFSClient.java:619)
> at 
> org.apache.hadoop.hdfs.DistributedFileSystem.initialize(DistributedFileSystem.java:149)
> at org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:2653)
> at org.apache.hadoop.fs.FileSystem.access$200(FileSystem.java:92)
> at org.apache.hadoop.fs.FileSystem$Cache.getInternal(FileSystem.java:2687)
> at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:2669)
> at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:371)
> at org.apache.hadoop.fs.Path.getFileSystem(Path.java:295)
> at 
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.init(CoprocessorClassLoader.java:165)
> at 
> org.apache.hadoop.hbase.util.CoprocessorClassLoader.getClassLoader(CoprocessorClassLoader.java:250)
> at 
> org.apache.hadoop.hbase.coprocessor.CoprocessorHost.load(CoprocessorHost.java:194)
> at 
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.loadTableCoprocessors(RegionCoprocessorHost.java:352)
> at 
> org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.<init>(RegionCoprocessorHost.java:240)
> at org.apache.hadoop.hbase.regionserver.HRegion.<init>(HRegion.java:749)
> at org.apache.hadoop.hbase.regionserver.HRegion.<init>(HRegion.java:657)
> at sun.reflect.GeneratedConstructorAccessor13.newInstance(Unknown Source)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at org.apache.hadoop.hbase.regionserver.HRegion.newHRegion(HRegion.java:6727)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7037)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7009)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6965)
> at org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:6916)
> at 
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.openRegion(OpenRegionHandler.java:362)
> at 
> org.apache.hadoop.hbase.regionserver.handler.OpenRegionHandler.process(OpenRegionHandler.java:129){code}
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to