[
https://issues.apache.org/jira/browse/HBASE-22453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16845615#comment-16845615
]
HBase QA commented on HBASE-22453:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
20m 16s{color} | {color:green} Patch does not cause any errors with Hadoop
2.8.5 2.9.2 or 3.0.3 3.1.2. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 14m 25s{color}
| {color:red} hbase-backup in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 60m 32s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.backup.TestBackupHFileCleaner |
| | hadoop.hbase.backup.TestBackupSmallTests |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/378/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22453 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12969360/HBASE-22453.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 46fe789fa705 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a30b186568 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/378/artifact/patchprocess/patch-unit-hbase-backup.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/378/testReport/ |
| Max. process+thread count | 368 (vs. ulimit of 10000) |
| modules | C: hbase-backup U: hbase-backup |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/378/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> A "NullPointerException" could be thrown; "tableDescriptor" is nullable
> -----------------------------------------------------------------------
>
> Key: HBASE-22453
> URL: https://issues.apache.org/jira/browse/HBASE-22453
> Project: HBase
> Issue Type: Bug
> Components: backup&restore
> Affects Versions: 2.0.0, 2.1.2, 2.1.4
> Reporter: lixiaobao
> Assignee: lixiaobao
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HBASE-22453.patch
>
>
> In hbase-backup model the class
> "org.apache.hadoop.hbase.backup.util.RestoreTool"'s method
> incrementalRestoreTable(),A "NullPointerException" could be thrown;
> "tableDescriptor" is nullable here.
> {code:java}
> // adjust table schema
> for (int i = 0; i < tableNames.length; i++) {
> TableName tableName = tableNames[i];
> TableDescriptor tableDescriptor = getTableDescriptor(fileSys, tableName,
> incrBackupId);
> LOG.debug("Found descriptor " + tableDescriptor + " through " +
> incrBackupId);
> TableName newTableName = newTableNames[i];
> TableDescriptor newTableDescriptor = admin.getDescriptor(newTableName);
> List<ColumnFamilyDescriptor> families =
> Arrays.asList(tableDescriptor.getColumnFamilies());
> List<ColumnFamilyDescriptor> existingFamilies =
> Arrays.asList(newTableDescriptor.getColumnFamilies());
> TableDescriptorBuilder builder =
> TableDescriptorBuilder.newBuilder(newTableDescriptor);
> boolean schemaChangeNeeded = false;
> for (ColumnFamilyDescriptor family : families) {
> if (!existingFamilies.contains(family)) {
> builder.setColumnFamily(family);
> schemaChangeNeeded = true;
> }
> }
> for (ColumnFamilyDescriptor family : existingFamilies) {
> if (!families.contains(family)) {
> builder.removeColumnFamily(family.getName());
> schemaChangeNeeded = true;
> }
> }
> if (schemaChangeNeeded) {
> modifyTableSync(conn, builder.build());
> LOG.info("Changed " + newTableDescriptor.getTableName() + " to: " +
> newTableDescriptor);
> }
> }
> RestoreJob restoreService = BackupRestoreFactory.getRestoreJob(conf);
> restoreService.run(logDirs, tableNames, newTableNames, false);
> }
> //代码占位符
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
