Apache9 commented on a change in pull request #248: HBASE-22459 Expose store
reader reference count
URL: https://github.com/apache/hbase/pull/248#discussion_r287191390
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
##########
@@ -126,6 +126,11 @@
*/
int getStorefilesCount();
+ /**
+ * @return Reference count over store
+ */
+ int getStoreRefCount();
Review comment:
If you mean this code sniff
` for (Store store : region.stores.values()) {`
` tempNumStoreFiles += store.getStorefilesCount();`
` tempStoreRefCount += store.getStoreRefCount();`
` tempMemstoreSize += store.getMemStoreSize().getDataSize();`
` tempStoreFileSize += store.getStorefilesSize();`
` OptionalLong storeMaxStoreFileAge = store.getMaxStoreFileAge();`
Actually you can just change the `for (Store store :
region.stores.values()) {` to `for (HStore store : region.stores.values()) {`,
as the `region` is a `HRegion`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
