[
https://issues.apache.org/jira/browse/HBASE-22469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847560#comment-16847560
]
Josh Elser commented on HBASE-22469:
------------------------------------
{quote}I also noticed that revision doesn't always show, case in point HBase
2.2.0 RC4 vote, revision=Unknown. In my tests, revision only appears if the
compiled code was cloned from git and not a release candidate download file
{quote}
Yeah, this is a result of the maven/git plugin(s) we have configured, IIRC.
Like you said, if you don't build from a git checkout, we can't know what the
revision was.
That said, it looks what saveVersion.sh does is conditionally regenerates the
Version.java file which has a checksum over all of the source files. Switching
that from md5 to sha512 seems fine, but I don't think it's giving us anything
new (other than eliminate glaring eyes from thinking that there is a problem).
It's not like a collision or someone figuring out somethign else that generates
our checksum would invalidate our security model.
+1 on qa, I think.
> replace md5 checksum in saveVersion script with sha512 for hbase version
> information
> ------------------------------------------------------------------------------------
>
> Key: HBASE-22469
> URL: https://issues.apache.org/jira/browse/HBASE-22469
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Environment: {code:java}
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T15:00:29-04:00)
> Maven home: /opt/apache-maven-3.6.1
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.6", arch: "x86_64", family: "mac"{code}
> Reporter: Artem Ervits
> Assignee: Artem Ervits
> Priority: Minor
> Attachments: HBASE-22469.v01.patch
>
>
> noticed that hbase version always prints out an md5 for source but since we
> long retired md5 from the releases, it makes sense to replace hbase version
> information as well. I also noticed that revision doesn't always show, case
> in point HBase 2.2.0 RC4 vote, revision=Unknown. In my tests, revision only
> appears if the compiled code was cloned from git and not a release candidate
> download file. In that sense, release candidates should be checked out rather
> than downloaded. This Jira only addresses replacement of the md5 sum.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
