[
https://issues.apache.org/jira/browse/HBASE-22434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847749#comment-16847749
]
Xu Cang commented on HBASE-22434:
---------------------------------
{code:java}
public static boolean isCleanServerCacheException(Throwable cur)
{code}
I found this method is confusing to me. If there is no exception found, it
returns true and causes clear cache action.
Is this the real intention?
And this part
{code:java}
boolean notCleanServerException =
(isSpeialException(cur) || cur instanceof DoNotRetryIOException);
// Exception like ConnectException should clean server's meta cache
return !notCleanServerException;{code}
Can this be cleant up a bit?
we can do something like
if (isSpecialException(curr) || cur instanceof DoNotRetryIOException) {
return fasle;
}
Meta cache behavior is crucial regarding HBase region access performance which
has high impact. We should treat this cautiously. Thanks!
> Improve clear meta cache
> ------------------------
>
> Key: HBASE-22434
> URL: https://issues.apache.org/jira/browse/HBASE-22434
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 2.2.0
> Reporter: binlijin
> Assignee: binlijin
> Priority: Major
> Attachments: HBASE-22434-master-v2.patch,
> HBASE-22434-master-v3.patch, cleanServerCache.jpg, cleanServerCache2.jpg
>
>
> 2.2.0 clear meta cache more aggressive and give more load to meta region,
> need to improve the clear logic. This is relate to the
> AsyncRequestFutureImpl#cleanServerCache logic.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
