openinx commented on a change in pull request #257: HBASE-22463 Some paths in
HFileScannerImpl did not consider block#release which will exhaust the
ByteBuffAllocator
URL: https://github.com/apache/hbase/pull/257#discussion_r288430534
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
##########
@@ -520,20 +520,18 @@ public HFileScannerImpl(final HFile.Reader reader, final
boolean cacheBlocks,
}
void updateCurrBlockRef(HFileBlock block) {
- if (block != null && this.curBlock != null &&
- block.getOffset() == this.curBlock.getOffset()) {
+ if (block != null && curBlock != null && block.getOffset() ==
curBlock.getOffset()) {
return;
}
- // We don't have to keep ref to EXCLUSIVE type of block
- if (this.curBlock != null && this.curBlock.usesSharedMemory()) {
Review comment:
FIled an separate issue for this:
https://issues.apache.org/jira/browse/HBASE-21879. Let finish that in an new
one because I believe it's will be many changes , also can helop to make this
PR forward.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
