[
https://issues.apache.org/jira/browse/HBASE-22496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851559#comment-16851559
]
Hudson commented on HBASE-22496:
--------------------------------
Results for branch branch-1.4
[build #821 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/821/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/821//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/821//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/821//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> UnsafeAccess.unsafeCopy should not copy more than UNSAFE_COPY_THRESHOLD on
> each iteration
> -----------------------------------------------------------------------------------------
>
> Key: HBASE-22496
> URL: https://issues.apache.org/jira/browse/HBASE-22496
> Project: HBase
> Issue Type: Improvement
> Reporter: Wellington Chevreuil
> Assignee: Wellington Chevreuil
> Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 1.4.10, 2.0.6, 2.1.5, 1.3.5
>
> Attachments: HBASE-22496.master.001.patch
>
>
> In *UnsafeAccess.unsafeCopy*, we calculate a _size_ __ to be read, no greater
> than UNSAFE_COPY_THRESHOLD, if total _len_ is larger than
> UNSAFE_COPY_THRESHOLD:
> {noformat}
> long size = (len > UNSAFE_COPY_THRESHOLD) ? UNSAFE_COPY_THRESHOLD : len;
> {noformat}
> But then we simply read the whole len anyway:
> {noformat}
> theUnsafe.copyMemory(src, srcAddr, dst, destAddr, len);
> {noformat}
> I believe the real intention here is to copy chunks of _size_ bytes, the
> current code is already copying everything on the first iteration, then
> performing additional chunked copies.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
