[
https://issues.apache.org/jira/browse/HBASE-22509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16852611#comment-16852611
]
HBase QA commented on HBASE-22509:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
56s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
3s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-1.4 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 4m
5s{color} | {color:red} root in branch-1.4 failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m
5s{color} | {color:red} hbase-server in branch-1.4 failed with JDK v1.8.0_212.
{color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
8s{color} | {color:red} hbase-server in branch-1.4 failed with JDK v1.7.0_222.
{color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
9s{color} | {color:red} The patch fails to run checkstyle in hbase-server
{color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
29s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
7s{color} | {color:red} hbase-server in branch-1.4 failed with JDK v1.8.0_212.
{color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
8s{color} | {color:red} hbase-server in branch-1.4 failed with JDK v1.7.0_222.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
9s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
24s{color} | {color:green} the patch passed with JDK v1.8.0_212 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 54s{color}
| {color:red} hbase-server-jdk1.8.0_212 with JDK v1.8.0_212 generated 6 new + 0
unchanged - 0 fixed = 6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
23s{color} | {color:green} the patch passed with JDK v1.7.0_222 {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 46s{color}
| {color:red} hbase-server-jdk1.7.0_222 with JDK v1.7.0_222 generated 6 new + 0
unchanged - 0 fixed = 6 total (was 0) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
30s{color} | {color:red} hbase-server: The patch generated 368 new + 0
unchanged - 0 fixed = 368 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 2m
48s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
31s{color} | {color:red} The patch causes 26 errors with Hadoop v2.4.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
59s{color} | {color:red} The patch causes 26 errors with Hadoop v2.5.2. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
55s{color} | {color:red} The patch causes 16 errors with Hadoop v2.6.5. {color}
|
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
35s{color} | {color:red} hbase-server-jdk1.8.0_212 with JDK v1.8.0_212
generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
46s{color} | {color:red} hbase-server-jdk1.7.0_222 with JDK v1.7.0_222
generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
23s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
32s{color} | {color:green} hbase-hadoop2-compat in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}142m 43s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
57s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}183m 8s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestMetaTableMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22509 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12970408/HBASE-22509-branch-1.4.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6fba5c54675e 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-1.4 / a4ac174 |
| maven | version: Apache Maven 3.0.5 |
| Default Java | 1.7.0_222 |
| Multi-JDK versions | /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/branch-mvninstall-root.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/branch-compile-hbase-server-jdk1.8.0_212.txt
|
| compile |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/branch-compile-hbase-server-jdk1.7.0_222.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess//testptch/patchprocess/maven-branch-checkstyle-hbase-server.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_212.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.7.0_222.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.8.0_212.txt
|
| javac |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.7.0_222.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/patch-javac-2.4.1.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/patch-javac-2.5.2.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/patch-javac-2.6.5.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0_212.txt
|
| javadoc |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_222.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/artifact/patchprocess/patch-unit-hbase-server.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/testReport/ |
| Max. process+thread count | 3986 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-hadoop2-compat hbase-server U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/460/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Address findbugs/spotbugs complaints (branch-1.4)
> --------------------------------------------------
>
> Key: HBASE-22509
> URL: https://issues.apache.org/jira/browse/HBASE-22509
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Major
> Fix For: 1.4.10
>
> Attachments: HBASE-22509-branch-1.4.patch
>
>
> FindBugs module:hbase-common
> Inconsistent synchronization of
> org.apache.hadoop.hbase.io.encoding.EncodedDataBlock$BufferGrabbingByteArrayOutputStream.ourBytes;
> locked 50% of time Unsynchronized access at EncodedDataBlock.java:50% of
> time Unsynchronized access at EncodedDataBlock.java:[line 258]
> FindBugs module:hbase-hadoop2-compat
> java.util.concurrent.ScheduledThreadPoolExecutor stored into
> non-transient field MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:[line 51]
> FindBugs module:hbase-server
> Possible null pointer dereference of r in
> org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection)
> Dereferenced at HStore.java:r in
> org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection)
> Dereferenced at HStore.java:[line 2840]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
