busbey commented on a change in pull request #2: HBASE-22393 HBOSS: Shaded
external dependencies to avoid conflicts with Hadoop and HBase.
URL: https://github.com/apache/hbase-filesystem/pull/2#discussion_r289438720
##########
File path: hbase-oss/pom.xml
##########
@@ -70,56 +71,206 @@
</systemProperties>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-shade-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>aggregate-into-a-jar-with-relocated-third-parties</id>
+ <phase>package</phase>
+ <goals>
+ <goal>shade</goal>
+ </goals>
+ <configuration>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review comment:
setting the location doesn't actually work. it's a long standing problem
with the shade plugin that keeps getting only half fixed.
this is why we don't change it's location in the main project repo's shaded
jar work. (or over in the hadoop project either)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
