[
https://issues.apache.org/jira/browse/HBASE-22515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853252#comment-16853252
]
Sean Mackrory commented on HBASE-22515:
---------------------------------------
Oh I see the confusion. Yeah I occasionally run -Pnull just to make sure the
failures are more or less what I expect (especially if I've modified those 2
tests in anyway), and usually it's obviously a case of non-atomic semantics.
But I was failing just because the test was testing specifically implementation
details below the interface layer. Yeah I'm not opposed to documenting that
those 2 tests should virtually always fail, and others may too but it should be
a case of non-atomic semantics. If it fails 100% of the time even when the
underlying storage is, say, HDFS, then it's a problem.
> Document HBOSS test cases known to fail under Null lock implementation
> ----------------------------------------------------------------------
>
> Key: HBASE-22515
> URL: https://issues.apache.org/jira/browse/HBASE-22515
> Project: HBase
> Issue Type: Task
> Components: Filesystem Integration
> Affects Versions: hbase-filesystem-1.0.0-alpha1
> Reporter: Sean Busbey
> Priority: Minor
>
> some existing test fail when the null locking implementation is used, because
> correctness relies on locks:
> {code}
> [INFO] Running org.apache.hadoop.hbase.oss.TestAtomicRename
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.661
> s <<< FAILURE! - in org.apache.hadoop.hbase.oss.TestAtomicRename
> [ERROR] testAtomicRename(org.apache.hadoop.hbase.oss.TestAtomicRename) Time
> elapsed: 1.498 s <<< FAILURE!
> java.lang.AssertionError: Rename source is still visible after rename
> finished or target showed up.
> at
> org.apache.hadoop.hbase.oss.TestAtomicRename.testAtomicRename(TestAtomicRename.java:73)
> [INFO] Running org.apache.hadoop.hbase.oss.TestCreateNonRecursive
> [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.088
> s <<< FAILURE! - in org.apache.hadoop.hbase.oss.TestCreateNonRecursive
> [ERROR]
> testCreateNonRecursiveParallel(org.apache.hadoop.hbase.oss.TestCreateNonRecursive)
> Time elapsed: 0.872 s <<< FAILURE!
> java.lang.AssertionError: All but exactly 1 call should have thrown
> exceptions. Experiment 1 of 10. expected:<9> but was:<0>
> at
> org.apache.hadoop.hbase.oss.TestCreateNonRecursive.testCreateNonRecursiveParallel(TestCreateNonRecursive.java:103)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
