[
https://issues.apache.org/jira/browse/HBASE-22508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853277#comment-16853277
]
Andrew Purtell commented on HBASE-22508:
----------------------------------------
The checkstyle result is actually an improvement, was 423, now 420. I looked
and they are javadoc nits i didn't touch. Out of scope for this work item. The
precommit result is good. The other precommit report on the PR also looks good.
I'm going to commit this in a few hours so I can move forward with the 1.3.5
RC.
> Address findbugs/spotbugs complaints (branch-1.3)
> --------------------------------------------------
>
> Key: HBASE-22508
> URL: https://issues.apache.org/jira/browse/HBASE-22508
> Project: HBase
> Issue Type: Bug
> Reporter: Andrew Purtell
> Assignee: Andrew Purtell
> Priority: Major
> Fix For: 1.3.5
>
> Attachments: HBASE-22508-branch-1.3.patch
>
>
> FindBugs module:hbase-hadoop2-compat
> java.util.concurrent.ScheduledThreadPoolExecutor stored into
> non-transient field MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:MetricsExecutorImpl$ExecutorSingleton.scheduler At
> MetricsExecutorImpl.java:[line 51]
> FindBugs module:hbase-server
> Possible null pointer dereference of walKey in
> org.apache.hadoop.hbase.regionserver.HRegion.append(Append, long, long)
> Dereferenced at HRegion.java:walKey in
> org.apache.hadoop.hbase.regionserver.HRegion.append(Append, long, long)
> Dereferenced at HRegion.java:[line 7815]
> Possible null pointer dereference of walKey in
> org.apache.hadoop.hbase.regionserver.HRegion.doIncrement(Increment, long,
> long) Dereferenced at HRegion.java:walKey in
> org.apache.hadoop.hbase.regionserver.HRegion.doIncrement(Increment, long,
> long) Dereferenced at HRegion.java:[line 8052]
> Possible null pointer dereference of r in
> org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection)
> Dereferenced at HStore.java:r in
> org.apache.hadoop.hbase.regionserver.HStore.removeCompactedfiles(Collection)
> Dereferenced at HStore.java:[line 2810]
> org.apache.hadoop.hbase.tool.Canary$RegionMonitor.run() makes
> inefficient use of keySet iterator instead of entrySet iterator At
> Canary.java:keySet iterator instead of entrySet iterator At Canary.java:[line
> 1095]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
