Ankit Singhal created HBASE-22528:
-------------------------------------

             Summary: unnecessary ERROR log in RS even the snapshot is 
completed successfully.
                 Key: HBASE-22528
                 URL: https://issues.apache.org/jira/browse/HBASE-22528
             Project: HBase
          Issue Type: Bug
          Components: snapshots
    Affects Versions: 1.4.9, 3.0.0, 2.2.0
            Reporter: Ankit Singhal
            Assignee: Ankit Singhal


{code}
2019-06-02 20:04:36,702 INFO  
[MASTER_TABLE_OPERATIONS-master/10.0.0.198:16000-0] 
snapshot.EnabledTableSnapshotHandler: Done waiting - online snapshot for t1_V
2019-06-02 20:04:36,803 INFO  
[MASTER_TABLE_OPERATIONS-master/10.0.0.198:16000-0] 
snapshot.TakeSnapshotHandler: Snapshot t1_V of table t1 completed
2019-06-02 20:04:36,803 ERROR 
[MASTER_TABLE_OPERATIONS-master/10.0.0.198:16000-0] 
snapshot.TakeSnapshotHandler: Couldn't delete snapshot working 
directory:file:/var/folders/1d/j2qwtjr141z69nc86syq8xb80000gn/T/hbase-asinghal/hbase/.hbase-snapshot/.tmp/t1_V
2019-06-02 20:04:36,804 INFO  [PEWorker-9] procedure2.ProcedureExecutor: 
Finished pid=11, state=SUCCESS; 
org.apache.hadoop.hbase.master.locking.LockProcedure, tableName=t1, type=SHARED 
in 213msec
{code}

We should be checking if the directory is present or not before deleting it.
https://github.com/apache/hbase/blame/branch-2.2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/TakeSnapshotHandler.java#L246





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to