[ 
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854568#comment-16854568
 ] 

Philippe Laflamme commented on HBASE-21415:
-------------------------------------------

[~elserj] noticed one problem with one of the comments. One of them is missing 
a period: 

{quote}sequentially even when requested concurrentlySnapshots are considered 
unique{quote}

Also, when it says

{quote}Snapshots are taken sequentially even when requested concurrently.{quote}

I would specify whether this is per table or globally (not sure which one it 
is). e.g.

if it's per table:
{quote}Snapshots are taken sequentially even when requested concurrently, per 
table.{quote}
or if it's globally:
{quote}Snapshots are taken sequentially even when requested concurrently, 
across all tables.{quote}

> Admin#snapshot method documentation is misleading.
> --------------------------------------------------
>
>                 Key: HBASE-21415
>                 URL: https://issues.apache.org/jira/browse/HBASE-21415
>             Project: HBase
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Philippe Laflamme
>            Assignee: Philippe Laflamme
>            Priority: Trivial
>         Attachments: HBASE-21415.002.patch, HBASE-21415.patch, 
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in 
> regards to snapshot concurrency.
> It currently states the following: 
> {quote}Only a single snapshot should be taken at a time for an instance of 
> HBase, or results may be undefined (you can tell multiple HBase clusters to 
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when 
> in fact the HBase master will simply run them sequentially (as per this Slack 
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to