[ 
https://issues.apache.org/jira/browse/HBASE-21415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854759#comment-16854759
 ] 

Josh Elser edited comment on HBASE-21415 at 6/3/19 4:16 PM:
------------------------------------------------------------

{quote}noticed one problem with one of the comments. One of them is missing a 
period: 
{quote}
-I'm not seeing this, Phillipe. Are you sure it's missing a period, or maybe 
the period is contained in code unchanged by the patch (e.g. on the next line)?-

Nevermind, I see it now. 


was (Author: elserj):
{quote}noticed one problem with one of the comments. One of them is missing a 
period: 
{quote}
I'm not seeing this, Phillipe. Are you sure it's missing a period, or maybe the 
period is contained in code unchanged by the patch (e.g. on the next line)?

> Admin#snapshot method documentation is misleading.
> --------------------------------------------------
>
>                 Key: HBASE-21415
>                 URL: https://issues.apache.org/jira/browse/HBASE-21415
>             Project: HBase
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Philippe Laflamme
>            Assignee: Philippe Laflamme
>            Priority: Trivial
>         Attachments: HBASE-21415.002.patch, HBASE-21415.patch, 
> HBASE-21415.patch
>
>
> The documentation for the {{Admin#snapshot}} function is misleading in 
> regards to snapshot concurrency.
> It currently states the following: 
> {quote}Only a single snapshot should be taken at a time for an instance of 
> HBase, or results may be undefined (you can tell multiple HBase clusters to 
> snapshot at the same time, but only one at a time for a single cluster).
> {quote}
> This seems to indicate that it's dangerous to run snapshots concurrently when 
> in fact the HBase master will simply run them sequentially (as per this Slack 
> thread [https://apache-hbase.slack.com/archives/C13K8NVAM/p1540994948005900)]
> The suggested fix is to simply remove this entire sentence.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to