saintstack commented on a change in pull request #291: HBASE-22550 Do not use
Threads.newDaemonThreadFactory in ConnectionUt…
URL: https://github.com/apache/hbase/pull/291#discussion_r291669273
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionOverAsyncConnection.java
##########
@@ -134,13 +139,25 @@ public boolean isClosed() {
return conn.isClosed();
}
+ private ThreadPoolExecutor createThreadPool() {
+ Configuration conf = conn.getConfiguration();
+ int threads = conf.getInt("hbase.hconnection.threads.max", 256);
Review comment:
Pool could spin up to 256 threads? The old client used to do this but I was
hoping new async client would leave behind old days and new async client would
run w/ a few threads only? It'd run smarter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
