[
https://issues.apache.org/jira/browse/HBASE-5619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238766#comment-13238766
]
[email protected] commented on HBASE-5619:
------------------------------------------------------
bq. On 2012-03-26 19:15:13, Benoit Sigoure wrote:
bq. > pom.xml, line 780
bq. > <https://reviews.apache.org/r/4054/diff/1-4/?file=86002#file86002line780>
bq. >
bq. > Just do "if which cygpath 2>/dev/null" instead of doing it on 2
lines and testing $?
Sure, will fix.
bq. On 2012-03-26 19:15:13, Benoit Sigoure wrote:
bq. > pom.xml, line 787
bq. > <https://reviews.apache.org/r/4054/diff/1-4/?file=86002#file86002line787>
bq. >
bq. > Just do "for PROTO_FILE in $UNIX_PROTO_DIR/*.proto", I don't think
the "ls" is really necessary here.
You are right. It works without "ls". Fixed.
bq. On 2012-03-26 19:15:13, Benoit Sigoure wrote:
bq. > pom.xml, line 334
bq. > <https://reviews.apache.org/r/4054/diff/1-4/?file=86002#file86002line334>
bq. >
bq. > Can you please kill all the trailing whitespaces while you're at it?
Sure, I will do that.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4054/#review6354
-----------------------------------------------------------
On 2012-03-23 19:29:52, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4054/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-23 19:29:52)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is the first draft of the ProtoBuff HRegionProtocol. The
corresponding java vs pb method mapping is attached to the jira:
https://issues.apache.org/jira/browse/HBASE-5443
bq.
bq. Please review. I'd like to move ahead after we get to some agreement.
bq.
bq.
bq. This addresses bug HBASE-5619.
bq. https://issues.apache.org/jira/browse/HBASE-5619
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. pom.xml 10b13ef
bq. src/main/proto/RegionAdmin.proto PRE-CREATION
bq. src/main/proto/RegionClient.proto PRE-CREATION
bq. src/main/proto/hbase.proto PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/4054/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> Create PB protocols for HRegionInterface
> ----------------------------------------
>
> Key: HBASE-5619
> URL: https://issues.apache.org/jira/browse/HBASE-5619
> Project: HBase
> Issue Type: Sub-task
> Components: ipc, master, migration, regionserver
> Reporter: Jimmy Xiang
> Assignee: Jimmy Xiang
> Fix For: 0.96.0
>
> Attachments: hbase-5619.patch
>
>
> Subtask of HBase-5443, separate HRegionInterface into admin protocol and
> client protocol, create the PB protocol buffer files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
