taklwu commented on a change in pull request #297: HBASE-22395 Document RC 
voting guidelines in ref guide
URL: https://github.com/apache/hbase/pull/297#discussion_r292593232
 
 

 ##########
 File path: src/main/asciidoc/_chapters/developer.adoc
 ##########
 @@ -899,6 +910,15 @@ Usage: hbase-vote.sh -s | --source <url> [-k | --key 
<signature>] [-f | --keys-f
                                 http://www.apache.org/dist/hbase/KEYS
   -o | --output-dir '</path>'   directory which has the stdout and stderr of 
each verification target
 ----
+** If you see any unit test failures, please call out the solo test result and 
whether it's part of flaky (nightly) tests dashboard. Link to the dashboard is 
e.g. 
https://builds.apache.org/view/H-L/view/HBase/job/HBase-Find-Flaky-Tests/job/<branch-name>/lastSuccessfulBuild/artifact/dashboard.html
 
 Review comment:
   fixed, I changed to master branch with a note one should change the test 
branch accordingly such we don't have to change this ref guide often. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to