anoopsjohn commented on a change in pull request #298: HBASE-22569 Should treat
null consistency as Consistency.STRONG in Co…
URL: https://github.com/apache/hbase/pull/298#discussion_r292765321
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##########
@@ -545,7 +545,7 @@ static void incRegionCountMetrics(ScanMetrics scanMetrics)
{
TableName tableName, Query query, byte[] row, RegionLocateType
locateType,
Function<Integer, CompletableFuture<T>> requestReplica, long
rpcTimeoutNs,
long primaryCallTimeoutNs, Timer retryTimer, Optional<MetricsConnection>
metrics) {
- if (query.getConsistency() == Consistency.STRONG) {
+ if (query.getConsistency() != Consistency.TIMELINE) {
Review comment:
Whether we will get this issue?
In Query we have
Consistency consistency = Consistency.STRONG
So the getConsistency always will return STRONG if not set right? Or u mean
if some one set like null as consistency?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
