Apache9 commented on a change in pull request #298: HBASE-22569 Should treat
null consistency as Consistency.STRONG in Co…
URL: https://github.com/apache/hbase/pull/298#discussion_r292946523
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
##########
@@ -545,7 +545,7 @@ static void incRegionCountMetrics(ScanMetrics scanMetrics)
{
TableName tableName, Query query, byte[] row, RegionLocateType
locateType,
Function<Integer, CompletableFuture<T>> requestReplica, long
rpcTimeoutNs,
long primaryCallTimeoutNs, Timer retryTimer, Optional<MetricsConnection>
metrics) {
- if (query.getConsistency() == Consistency.STRONG) {
+ if (query.getConsistency() != Consistency.TIMELINE) {
Review comment:
In PE we will set it to null... And we do not prevent users to set it to
null so we should take care of this...
Maybe we can file another 'incompatible issue' to not allow users to set it
to null, maybe by throwing an exception, but anyway, I do not think we can do
this in branch-2 so we still need the patch here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
