mackrorysd commented on a change in pull request #5: HBASE-22574
hbase-filesystem does not build against HBase 1
URL: https://github.com/apache/hbase-filesystem/pull/5#discussion_r293825978
##########
File path: pom.xml
##########
@@ -126,5 +119,79 @@
<hadoop.version>${hadoop3.version}</hadoop.version>
</properties>
</profile>
+ <profile>
+ <!-- default HBase profile -->
+ <id>hbase2</id>
+ <activation>
+ <property>
+ <name>!hbase.profile</name>
+ </property>
+ </activation>
+ <properties>
+ <hbase.version>${hbase2.version}</hbase.version>
+ </properties>
+ <!-- For testing against ZK -->
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-zookeeper</artifactId>
+ <version>${hbase2.version}</version>
Review comment:
There are tabs being used here and spaces everywhere else. I'm fine with
either, but let's be consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
