wchevreuil commented on a change in pull request #307: HBase 22537
URL: https://github.com/apache/hbase/pull/307#discussion_r293917693
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/UnassignProcedure.java
##########
@@ -231,6 +231,7 @@ protected void finishTransition(final MasterProcedureEnv
env, final RegionStateN
} else {
// Remove from in-memory states
am.getRegionStates().deleteRegion(regionInfo);
+
am.getRegionStates().removeRegionFromServer(regionNode.getRegionLocation(),
regionNode);
env.getMasterServices().getServerManager().removeRegion(regionInfo);
Review comment:
This is my proposal. The main reason for the issue is that we are missing
removing read replicas from this cache. Once the RS the replica once was
assigned to crashes, the originated SCP will read this cache and find the
**read replica** (that does not really exist anywhere else, at this point), and
will submit an AP for it. Adding this extra cleanup, allowed your test to
succeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
