virajjasani commented on a change in pull request #310: [HBASE-22591] :
RecoverableZooKeeper improvement for getData, getChil…
URL: https://github.com/apache/hbase/pull/310#discussion_r294092031
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
##########
@@ -205,12 +203,21 @@ public void delete(String path, int version) throws
InterruptedException, Keeper
* @return A Stat instance
*/
public Stat exists(String path, Watcher watcher) throws KeeperException,
InterruptedException {
+ return getStatInstance(path, watcher, null);
+ }
+
+ private Stat getStatInstance(String path, Watcher watcher, Boolean watch)
+ throws InterruptedException, KeeperException {
try (TraceScope scope =
TraceUtil.createTrace("RecoverableZookeeper.exists")) {
Review comment:
It’s true that the scope variable isn’t used anywhere. However, that is how
it is used with try-with-resources in most of the cases in this project to
create htrace and then close it.
Are you suggesting to keep it this way: try(TraceUtil.createTrace()) ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
