anoopsjohn commented on a change in pull request #318: HBASE-22598 Deprecated the hbase.ipc.server.reservoir.initial.buffer.… URL: https://github.com/apache/hbase/pull/318#discussion_r294231173
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java ########## @@ -68,9 +68,25 @@ // default heap allocator, it will just allocate ByteBuffers from heap but wrapped by an ByteBuff. public static final ByteBuffAllocator HEAP = ByteBuffAllocator.createOnHeap(); - public static final String MAX_BUFFER_COUNT_KEY = "hbase.ipc.server.allocator.max.buffer.count"; + public static final String MAX_BUFFER_COUNT_KEY = "hbase.server.allocator.max.buffer.count"; Review comment: Previously the BBPool was used by the IPC/RPC server component alone. The name came that way. HBase IPC server config. Now it is used other places too. So better just say the BBPool related configs used in server. BTW we name it like Allocator now instead of direct refer to pool. So fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
