wchevreuil commented on a change in pull request #310: [HBASE-22591] :
RecoverableZooKeeper improvement for getData, getChil…
URL: https://github.com/apache/hbase/pull/310#discussion_r294262388
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
##########
@@ -277,12 +262,21 @@ private void retryOrThrow(RetryCounter retryCounter,
KeeperException e,
*/
public List<String> getChildren(String path, Watcher watcher)
throws KeeperException, InterruptedException {
+ return getChildrenUtils(path, watcher, null);
+ }
+
+ private List<String> getChildrenUtils(String path, Watcher watcher, Boolean
watch)
Review comment:
Similar to my previous comment, maybe simply overload _getChildren_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
