wchevreuil commented on a change in pull request #323: HBASE-22414 Interruption
of moving regions in RSGroup will cause regi…
URL: https://github.com/apache/hbase/pull/323#discussion_r295706100
##########
File path:
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##########
@@ -247,23 +255,49 @@ private void moveServerRegionsFromGroup(Set<Address>
servers, String targetGroup
*/
private void moveTableRegionsToGroup(Set<TableName> tables, String
targetGroupName)
Review comment:
This method structure became very similar to _moveServerRegionsFromGroup_.
Could we define a skeleton method for code reuse? Same remarks made above for
_moveServerRegionsFromGroup_ would also apply here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
