openinx commented on a change in pull request #163: HBASE-21995 Add a
coprocessor to set HDFS ACL for hbase granted user
URL: https://github.com/apache/hbase/pull/163#discussion_r295685706
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/PermissionStorage.java
##########
@@ -839,17 +840,21 @@ private static boolean validateCFAndCQ(byte[]
permFamily, byte[] cf, byte[] perm
}
public static boolean isGlobalEntry(byte[] entryName) {
- return entryName != null &&
TableName.valueOf(entryName).equals(ACL_TABLE_NAME);
+ return entryName != null && Bytes.equals(entryName, ACL_GLOBAL_NAME);
Review comment:
Just return `Bytes.equals(entryName, ACL_GLOBAL_NAME)` ? The Bytes#equals
will handle the null case, no need the extra `entryName != null` check ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
