[ 
https://issues.apache.org/jira/browse/HBASE-22617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16870064#comment-16870064
 ] 

Duo Zhang commented on HBASE-22617:
-----------------------------------

{quote}
We can patch to look in both locations, and clean up wherever files may have 
been written. At some future time this transitional code can be removed.
{quote}

This is exactly what HBASE-20734 has done. We will clean up all the files but 
the problem here is that, the directories will leave there forever...

We can remove the recovered.edits directory, but we can not remove the parent 
directories as maybe some others are still using them. In the old time, this is 
fine, as the recovered.edits directory is located together with region 
directories, it will be gone when we delete the region directories. But now, if 
we locate the recovered.edits other than the default place, the directories 
will be there for ever...

> Recovered WAL directories not getting cleaned up
> ------------------------------------------------
>
>                 Key: HBASE-22617
>                 URL: https://issues.apache.org/jira/browse/HBASE-22617
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 1.5.0
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Blocker
>             Fix For: 3.0.0, 1.5.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6, 1.4.11
>
>
> While colocating the recovered edits directory with hbase.wal.dir, 
> BASE_NAMESPACE_DIR got missed. This results in recovered edits being put in a 
> separate directory rather than the default region directory even if the 
> hbase.wal.dir is not overridden. Eg. if data is stored in 
> /hbase/data/namespace/table1, recovered edits are put in  
> /hbase/namespace/table1. This also messes up the regular cleaner chores which 
> never operate on this new directory and these directories will never be 
> deleted, even for split parents or dropped tables. We should change the 
> default back to have the base namespace directory in path.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to