wchevreuil commented on a change in pull request #324: [HBASE-22606] : BucketCache additional tests URL: https://github.com/apache/hbase/pull/324#discussion_r296482030
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java ########## @@ -114,8 +113,8 @@ /** Priority buckets */ @VisibleForTesting static final float DEFAULT_SINGLE_FACTOR = 0.25f; - static final float DEFAULT_MULTI_FACTOR = 0.50f; - static final float DEFAULT_MEMORY_FACTOR = 0.25f; + private static final float DEFAULT_MULTI_FACTOR = 0.50f; Review comment: Yeah, having specific jiras for each fix is generally preferred. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
