virajjasani commented on a change in pull request #333: [HBASE-22606] : 
BucketCache additional tests
URL: https://github.com/apache/hbase/pull/333#discussion_r296840732
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/bucket/TestBucketCache.java
 ##########
 @@ -136,7 +135,7 @@ public void cacheBlock(BlockCacheKey cacheKey, Cacheable 
buf) {
   @Before
   public void setup() throws IOException {
     cache = new MockedBucketCache(ioEngineName, capacitySize, 
constructedBlockSize,
-        constructedBlockSizes, writeThreads, writerQLen, persistencePath);
 
 Review comment:
   Since persistencePath was defined as null and was not getting updated in the 
file ever after, I thought of removing the declaration and directly putting null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to