z-york commented on a change in pull request #339: HBASE-22627 Port HBASE-22617
(Recovered WAL directories not getting cleaned up) to branch-1
URL: https://github.com/apache/hbase/pull/339#discussion_r297358564
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DeleteTableProcedure.java
##########
@@ -332,6 +331,13 @@ protected static void deleteFromFs(final
MasterProcedureEnv env,
if (!fs.delete(tempTableDir, true) && fs.exists(tempTableDir)) {
throw new IOException("Couldn't delete " + tempTableDir);
}
+
+ // Delete the directory on wal filesystem
+ FileSystem walFs = mfs.getWALFileSystem();
+ Path tableWALDir = FSUtils.getWALTableDir(env.getMasterConfiguration(),
tableName);
+ if (walFs.exists(tableWALDir) && !walFs.delete(tableWALDir, true)) {
Review comment:
Will this have any unintended side-effects(rollbacks?)? Will this eventually
be cleaned up by the cleaners?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
