apurtell commented on a change in pull request #339: HBASE-22627 Port
HBASE-22617 (Recovered WAL directories not getting cleaned up) to branch-1
URL: https://github.com/apache/hbase/pull/339#discussion_r297362904
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
##########
@@ -640,19 +640,26 @@ Path commitDaughterRegion(final HRegionInfo regionInfo)
/**
* Create the region splits directory.
*/
- void createSplitsDir() throws IOException {
+ void createSplitsDir(HRegionInfo daughterA, HRegionInfo daughterB) throws
IOException {
Review comment:
I believe this fixed an issue with a hbck test so precommit for the branch-2
version could be green. The daughter directories would not always be created.
While technically an unrelated change we allowed it there and should allow it
here. Or do an addendum to break it out into a separate commit (here and in
branch-2 and up).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
