[
https://issues.apache.org/jira/browse/HBASE-22634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16873557#comment-16873557
]
HBase QA commented on HBASE-22634:
----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} branch-2.1 Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
5s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
22s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
33s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
58s{color} | {color:green} branch-2.1 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
20s{color} | {color:green} branch-2.1 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
25s{color} | {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
21s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
35s{color} | {color:red} hbase-client: The patch generated 158 new + 51
unchanged - 1 fixed = 209 total (was 52) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
6s{color} | {color:red} patch has 11 errors when building our shaded downstream
artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
17s{color} | {color:red} The patch causes 11 errors with Hadoop v2.7.7. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
34s{color} | {color:red} The patch causes 11 errors with Hadoop v2.8.5. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
50s{color} | {color:red} The patch causes 11 errors with Hadoop v3.0.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
6s{color} | {color:red} The patch causes 11 errors with Hadoop v3.1.2. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m
8s{color} | {color:red} hbase-client generated 6 new + 0 unchanged - 0 fixed =
6 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 23s{color}
| {color:red} hbase-client in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| |
org.apache.hadoop.hbase.client.AsyncRequestFutureImpl.sendMultiAction(Map, int,
List, boolean) calls Thread.sleep() with a lock held At
AsyncRequestFutureImpl.java:Thread.sleep() with a lock held At
AsyncRequestFutureImpl.java:[line 592] |
| | Inconsistent synchronization of
org.apache.hadoop.hbase.client.BufferedMutatorImpl.writeBufferPeriodicFlushTimer;
locked 50% of time Unsynchronized access at BufferedMutatorImpl.java:50% of
time Unsynchronized access at BufferedMutatorImpl.java:[line 298] |
| | org.apache.hadoop.hbase.client.BufferedMutatorImpl.close() calls
Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At
BufferedMutatorImpl.java:[line 251] |
| | org.apache.hadoop.hbase.client.BufferedMutatorImpl.doFlush(boolean) calls
Thread.sleep() with a lock held At BufferedMutatorImpl.java:lock held At
BufferedMutatorImpl.java:[line 368] |
| | org.apache.hadoop.hbase.client.BufferedMutatorImpl.flush() does not
release lock on all paths At BufferedMutatorImpl.java:on all paths At
BufferedMutatorImpl.java:[line 299] |
| | Dead store to f in
org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread,
Runnable) At
BufferedMutatorThreadPoolExecutor.java:org.apache.hadoop.hbase.client.BufferedMutatorThreadPoolExecutor.beforeExecute(Thread,
Runnable) At BufferedMutatorThreadPoolExecutor.java:[line 86] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/Dockerfile
|
| JIRA Issue | HBASE-22634 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12972992/HBASE-22634.001.branch-2.1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 96006ec32287 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed Feb
13 15:00:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.1 / a172b480fe |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| findbugs | v3.1.11 |
| mvninstall |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-mvninstall-root.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/diff-checkstyle-hbase-client.txt
|
| shadedjars |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-shadedjars.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-javac-2.7.7.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-javac-2.8.5.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-javac-3.0.3.txt
|
| hadoopcheck |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-javac-3.1.2.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/new-findbugs-hbase-client.html
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/artifact/patchprocess/patch-unit-hbase-client.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/testReport/ |
| Max. process+thread count | 82 (vs. ulimit of 10000) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/581/console |
| Powered by | Apache Yetus 0.9.0 http://yetus.apache.org |
This message was automatically generated.
> Improve performance of BufferedMutator
> --------------------------------------
>
> Key: HBASE-22634
> URL: https://issues.apache.org/jira/browse/HBASE-22634
> Project: HBase
> Issue Type: Improvement
> Components: Client
> Affects Versions: 2.1.5
> Environment: HDP 2.6.5
> Linux RedHat
> Reporter: Sebastien Barnoud
> Priority: Major
> Attachments: HBASE-22634.001.branch-2.1.patch
>
>
> The default ThreadPoolExecutor uses a default size of 1 (property
> hbase.htable.threads.max). When using a size > 1, we still encountered poor
> performance and exception while submitting to the pool (pool exceed its
> capacity).
> This patch propose a fix on different issues encountered when the pool size
> is > 1:
> * thread safety issue
> * concurrent cleanup by Netty and the "legacy" code
> * errors in the backpressure
> * Netty memory leak
> And propose a BufferedMutatorThreadPoolExecutor which:
> * uses hbase.client.max.total.tasks as the default size (instead of 1)
> * some usefull metrics
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
