sbarnoud commented on a change in pull request #343: HBASE-22634 : Improve
performance of BufferedMutator
URL: https://github.com/apache/hbase/pull/343#discussion_r298075417
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/AbstractRpcClient.java
##########
@@ -491,13 +482,13 @@ public void close() {
connToClose = connections.values();
connections.clear();
}
- cleanupIdleConnectionTask.cancel(true);
for (T conn : connToClose) {
- conn.shutdown();
+ // conn may be null in case of cancellation
+ if (conn != null) conn.shutdown();
Review comment:
The key in the map is not null, but the value ....
`connections.removeValue(conn.remoteId(), conn);`
I tried to contribute this patch because i get around a 10x throughput and a
lot of error/warn message less.
By "unlocking" the client bottleneck, i found a server bug (HBASE-22492) and
solve it.
Now, if to share this i have to spend a lot of time to justify such peace of
code, i will give up.
For my own use, this patch is already in production.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
