anoopsjohn commented on a change in pull request #341: HBASE-22582 The
Compaction writer may access the lastCell whose memor…
URL: https://github.com/apache/hbase/pull/341#discussion_r298087245
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -311,13 +311,9 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
// logging at DEBUG level
if (LOG.isDebugEnabled()) {
if ((now - lastMillis) >= COMPACTION_PROGRESS_LOG_INTERVAL) {
- LOG.debug("Compaction progress: "
- + compactionName
- + " "
- + progress
- + String.format(", rate=%.2f kB/sec",
(bytesWrittenProgressForLog / 1024.0)
- / ((now - lastMillis) / 1000.0)) + ", throughputController
is "
- + throughputController);
+ double rate = (bytesWrittenProgressForLog / 1024.0) / ((now -
lastMillis) / 1000.0);
Review comment:
What abt the String formatting on the Double value which we were doing.
Missing that in log now. Below one more place too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
