[ https://issues.apache.org/jira/browse/HBASE-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239964#comment-13239964 ]
Hudson commented on HBASE-5639: ------------------------------- Integrated in HBase-0.94 #61 (See [https://builds.apache.org/job/HBase-0.94/61/]) HBASE-5639 The logic used in waiting for region servers during startup is broken (J-D and NKeyval) (Revision 1306011) Result = FAILURE larsh : Files : * /hbase/branches/0.94/CHANGES.txt * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java > The logic used in waiting for region servers during startup is broken > --------------------------------------------------------------------- > > Key: HBASE-5639 > URL: https://issues.apache.org/jira/browse/HBASE-5639 > Project: HBase > Issue Type: Bug > Reporter: Jean-Daniel Cryans > Assignee: Jean-Daniel Cryans > Priority: Blocker > Fix For: 0.94.0 > > Attachments: HBASE-5639.patch > > > See the tail of HBASE-4993, which I'll report here: > Me: > {quote} > I think a bug was introduced here. Here's the new waiting logic in > waitForRegionServers: > the 'hbase.master.wait.on.regionservers.mintostart' is reached AND > there have been no new region server in for > 'hbase.master.wait.on.regionservers.interval' time > And the code that verifies that: > !(lastCountChange+interval > now && count >= minToStart) > {quote} > Nic: > {quote} > It seems that changing the code to > (count < minToStart || > lastCountChange+interval > now) > would make the code works as documented. > If you have 0 region servers that checked in and you are under the interval, > you wait: (true or true) = true. > If you have 0 region servers but you are above the interval, you wait: (true > or false) = true. > If you have 1 or more region servers that checked in and you are under the > interval, you wait: (false or true) = true. > {quote} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira