openinx commented on a change in pull request #337: HBASE-22578 HFileCleaner
should not delete empty ns/table directories…
URL: https://github.com/apache/hbase/pull/337#discussion_r298167920
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##########
@@ -407,6 +407,15 @@ private boolean checkAndDeleteFiles(List<FileStatus>
files) {
return deleteFiles(filesToDelete) == files.size();
}
+ /**
+ * Check if the directory can be deleted
+ * @param dir The path of a directory
+ * @return True if the directory can be deleted, otherwise false
+ */
+ boolean shouldDeleteDirectory(Path dir) {
Review comment:
isDirDeletable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
