HorizonNet commented on a change in pull request #316: HBASE-22595 Changed suppressions to full qualified class name URL: https://github.com/apache/hbase/pull/316#discussion_r298485017
########## File path: hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml ########## @@ -36,13 +36,13 @@ <suppress checks="MagicNumberCheck" files=".*/src/test/.*\.java"/> <suppress checks="VisibilityModifier" files=".*/src/test/.*\.java"/> <suppress checks="InterfaceIsTypeCheck" files=".*/src/main/.*\.java"/> - <suppress checks="EmptyBlockCheck" files="TBoundedThreadPoolServer.java"/> - <suppress checks="EmptyBlockCheck" files="TestServletFilter.java"/> - <suppress checks="EmptyBlockCheck" files="TestGlobalFilter.java"/> - <suppress checks="EmptyBlockCheck" files="TestPathFilter.java"/> - <suppress checks="EqualsHashCode" files="StartcodeAgnosticServerName.java"/> - <suppress checks="MethodLength" files="Branch1CoprocessorMethods.java"/> + <suppress checks="EmptyBlockCheck" files="org.apache.hadoop.hbase.thrift.TBoundedThreadPoolServer.java"/> + <suppress checks="EmptyBlockCheck" files="org.apache.hadoop.hbase.http.TestServletFilter.java"/> + <suppress checks="EmptyBlockCheck" files="org.apache.hadoop.hbase.http.TestGlobalFilter.java"/> + <suppress checks="EmptyBlockCheck" files="org.apache.hadoop.hbase.http.TestPathFilter.java"/> + <suppress checks="EqualsHashCode" files="org.apache.hadoop.hbase.favored.StartcodeAgnosticServerName.java"/> Review comment: Not sure if is correct, but it is consistent. This class relates to `ServerName.NON_STARTCODE`, which should be `ServerName.NON_START_CODE` if the name changes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
